-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and (mostly) clear npm audit #189
Update dependencies and (mostly) clear npm audit #189
Conversation
@gorner Looks good, could you rebase and fix the couple merge conflicts. |
32df572
to
0503b81
Compare
@jbailey4 Done. |
While you're in here, is there any chance you would be able to bump the 'broccoli-funnel' dependency to 2.0.1 (the latest)? npm is still throwing a deprecation warning for 'exists-sync', which 'broccoli-funnel' depended on until version 2.0.1. According to their changelog, it looks like the reason for the major version bump was simply because they dropped support for node 0.12. Meanwhile, this PR already declares node 6.x as the minimum supported version for 'ember-cli-sass'. |
Friendly bump. Would love to see this merged as it will remove a few distracting build warnings from our app now that broccoli-funnel is updated here. |
bump - this is the last addon we use that requires babel 5.x |
@aexmachina if there's any other assistance you need from my end for this, please let me know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for this - and thanks for the reminder.
I assume that this would be a patch-level version bump? |
@aexmachina The change in acceptable node versions (package.json line 61) might be interpreted as a breaking change, though Node 4.x has been already end-of-life since this past April. Otherwise I don't see anything that would qualify as an enhancement or breaking change. Edit: on second thought, perhaps the updated (prod) dependencies would suggest an enhancement-level bump? |
I have seen other addons mark a major version when dropping node 4. |
Okay good point. I've published v9.0.1 |
ember-cli-update
to update ember-cli addon blueprint to3.33.4, and updated acceptance tests to work with current test APIsnpm audit
issues; resolves hoek security issue (downstream dependency) #187(but excluding one minor issue dependent on pending ember-try 1.0 release)