feat: prevent fouc in development #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julien-R44
added a commit
to adonisjs/inertia
that referenced
this pull request
Mar 25, 2024
As it now handled directly by adonisjs/vite. See adonisjs/vite#12
Julien-R44
added a commit
that referenced
this pull request
Jun 2, 2024
* feat: prevent fouc in development * fix: test failing on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
generateEntryPointsTagsis now asyncThis PR prevents the FOUC that occurs in development when a user imports his CSS from javascript.
Sort of "backported" from adonisjs/inertia#5
The implementation is exactly the same, but made more generic. The adonisjs/inertia implementation can now be removed.
As a result, FOUC will be avoided on adonisjs+edge adonisjs+tsx and adonisjs+inertia stacks, without any additional code
Should close #10