Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add connectionString option to PostgresConnectionNode type #972

Closed
wants to merge 1 commit into from

Conversation

loadnull
Copy link

@loadnull loadnull commented Nov 7, 2023

Proposed changes

Add the connectionString option to the Postgres connection config.

See: https://node-postgres.com/features/connecting#connection-uri

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

Using the connection.connectionString option instead of just setting connection to the Postgres URI allows you to also set the connection.ssl options.

@thetutlage
Copy link
Member

The types are broken after the change, can you please look into it?

@loadnull
Copy link
Author

Just tried npx tsc on a fresh clone of the develop branch and it fails with the same error so it's not specific to this PR.

Not sure how to resolve.

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Abandoned Dropped and not into consideration label Mar 17, 2024
@loadnull loadnull closed this by deleting the head repository Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Abandoned Dropped and not into consideration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants