New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip undefined values in merge #1067

Closed

adamcikado wants to merge 1 commit into adonisjs:21.x from adamcikado:fix/merge

Contributor

adamcikado commented Nov 22, 2024 •

edited

Loading

🔗 Linked issue

❓ Type of change

🐞 Bug fix (a non-breaking change that fixes an issue)

📚 Description

Resolves #1066 .

PS: It seems like a lot of changes in the PR but I just moved the condition to top:

if (!isObject(values)) {
  return this
}

so it's more readable.

And added:

if (value === undefined) {
  return
}

📝 Checklist

I have linked an issue or discussion.


          fix: skip undefined values in merge

10d546b

adamcikado closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet