Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use updated svelte 5 functions #51

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

p1u3o
Copy link
Contributor

@p1u3o p1u3o commented Dec 29, 2024

πŸ”— Linked issue

adonisjs/inertia-starter-kit#7

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Svelte 5 changes how the applications is mounted, the inertia adapter needs to change to support them. I've also removed the SSR check in the template, now matching the behaviour used by the Laravel adapter.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Julien-R44
Copy link
Member

LGTM ! Thanks for the PR

@Julien-R44 Julien-R44 merged commit 1784684 into adonisjs:2.x Jan 3, 2025
@Julien-R44 Julien-R44 mentioned this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants