Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistencies in type parameters for samplers #35

Closed
slwu89 opened this issue Mar 2, 2024 · 0 comments · Fixed by #40
Closed

inconsistencies in type parameters for samplers #35

slwu89 opened this issue Mar 2, 2024 · 0 comments · Fixed by #40
Assignees
@adolgert

Comments

@slwu89
Copy link
Collaborator

slwu89 commented Mar 2, 2024

FirstToFire takes K,T as type parameters, for keys and the type that stores time. Other samples (CombinedNextReaction) and others only take a key type parameter. We should try to make them all take the same number of type parameters, if possible.
@slwu89 slwu89 mentioned this issue Mar 2, 2024
Closed
@adolgert adolgert self-assigned this Mar 4, 2024
@adolgert adolgert linked a pull request Mar 4, 2024 that will close this issue
35 inconsistencies in type parameters for samplers #40
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adolgert adolgert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

35 inconsistencies in type parameters for samplers adolgert/CompetingClocks.jl
2 participants
@adolgert @slwu89