Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

35 inconsistencies in type parameters for samplers #40

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

adolgert
Copy link
Owner

@adolgert adolgert commented Mar 4, 2024

All samplers now take two arguments to their constructor: KeyType and TimeType, where TimeType is an AbstractFloat. This will support Float32 and Float64. I don't think we can do integer times because that makes this a discrete-time simulation.

@adolgert adolgert linked an issue Mar 4, 2024 that may be closed by this pull request
@adolgert adolgert merged commit f09169d into main Mar 4, 2024
7 checks passed
@adolgert adolgert deleted the 35-inconsistencies-in-type-parameters-for-samplers branch March 4, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistencies in type parameters for samplers
1 participant