[trivial] Updating titles so that they no longer collide #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please approve for next release. |
ktukker-adobe
suggested changes
Sep 7, 2018
| @@ -7,7 +7,7 @@ | |||
| ], | |||
| "$id": "https://ns.adobe.com/experience/experienceevent", | |||
| "$schema": "http://json-schema.org/draft-06/schema#", | |||
| "title": "ExperienceEvent", | |||
| "title": "Adobe Experience Platform extensions to ExperienceEvent", | |||
There was a problem hiding this comment.
Adobe Cloud Platform - Data Services extension to...
| @@ -7,7 +7,7 @@ | |||
| ], | |||
| "$id": "https://ns.adobe.com/experience/profile/experienceevent", | |||
| "$schema": "http://json-schema.org/draft-06/schema#", | |||
| "title": "ExperienceEvent", | |||
| "title": "Adobe Profile Service extension to ExperienceEvent", | |||
There was a problem hiding this comment.
Unified Profile Service extension to
kstreeter
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of schema titles collide and make it difficult to understand what schema is which when only the title is exposed in a user experience. This PR corrects that issue, and uses the same pattern for naming the ExperienceEvent schema extensions as have been used with the other extensions in the project.