Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 484 - fix linting issues in extensions folder #485

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Issue 484 - fix linting issues in extensions folder #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/adobe/experience/adcloud/advertisement.example.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
"xdm:adClass": "video",
"xdm:adUnitType": "HTML5",
"xdm:promotedAssetId": "4116761052"
}
}
19 changes: 11 additions & 8 deletions extensions/adobe/experience/adcloud/advertisement.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,17 @@
"title": "Ad ID",
"type": "string",
"description":
"Unique identifier for the ad this event is associated with. Not to be confused with Ad-ID standard."
"Unique identifier for the ad this event is associated with. Not to be confused with Ad-ID standard."
},
"xdm:runtime": {
"title": "Runtime Type",
"type": "string",
"description": "The runtime of the ad unit itself, not the runtime of the browser or the operating system.",
"description":
"The runtime of the ad unit itself, not the runtime of the browser or the operating system.",
"meta:enum": {
"unknown": "Unknown",
"HTML5": "HTML5"
}
}
},
"xdm:adClass": {
"title": "Ad Class",
Expand All @@ -36,12 +37,13 @@
"display": "Display",
"video": "Video",
"social": "Social"
}
}
},
"xdm:adUnitType": {
"title": "Ad Unit Type",
"type": "string",
"description": "Unique identifier for the literal piece of code driving display of the ad in a browser/device.",
"description":
"Unique identifier for the literal piece of code driving display of the ad in a browser/device.",
"meta:enum": {
"linearVideo": "Linear video",
"interactiveVideo": "Interactive video",
Expand All @@ -52,16 +54,17 @@
"HTML5": "HTML5",
"inPageVideo": "In page video",
"inPageDisplay": "In page display",
"facebook":"Facebook",
"facebook": "Facebook",
"twitter": "Twitter",
"linearTv": "Linear TV",
"vod": "Video on Demand"
}
}
},
"xdm:promotedAssetId": {
"title": "Promoted Asset ID",
"type": "string",
"description": "Unique identifier for the underlying asset being promoted in the ad which this event is associated with."
"description":
"Unique identifier for the underlying asset being promoted in the ad which this event is associated with."
}
}
}
Expand Down
23 changes: 15 additions & 8 deletions extensions/adobe/experience/adcloud/campaign.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,44 +17,51 @@
"title": "Account ID",
"type": "string",
"description":
"Unique identifier for the account this event is associated with."
"Unique identifier for the account this event is associated with."
},
"xdm:campaignId": {
"title": "Campaign ID",
"type": "string",
"description": "Unique identifier for the campaign which this event is associated with."
"description":
"Unique identifier for the campaign which this event is associated with."
},
"xdm:placementId": {
"title": "Placement ID",
"type": "string",
"description": "Unique identifier for the placement which this event is associated with."
"description":
"Unique identifier for the placement which this event is associated with."
},
"xdm:packageId": {
"title": "Package ID",
"type": "string",
"description": "Unique identifier for the package which this event is associated with."
"description":
"Unique identifier for the package which this event is associated with."
},
"xdm:advertiserId": {
"title": "Advertiser ID",
"type": "string",
"description": "Unique identifier for the advertiser which this event is associated with."
"description":
"Unique identifier for the advertiser which this event is associated with."
},
"xdm:experimentId": {
"title": "Experiment ID",
"type": "string",
"description": "Unique identifier for the experiment which this event is associated with."
"description":
"Unique identifier for the experiment which this event is associated with."
},
"xdm:sampleGroupId": {
"title": "Sample Group ID",
"type": "string",
"description": "Unique identifier for the sample group which this event is associated with."
"description":
"Unique identifier for the sample group which this event is associated with."
},
"xdm:currency": {
"title": "Account Currency",
"type": "string",
"examples": ["USD", "EUR"],
"pattern": "^[A-Z]{3}$",
"description": "The ISO 4217 billing currency code for the account this event is associated with."
"description":
"The ISO 4217 billing currency code for the account this event is associated with."
}
}
}
Expand Down
12 changes: 5 additions & 7 deletions extensions/adobe/experience/adcloud/experienceevent.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,27 +22,25 @@
"https://ns.adobe.com/experience/adcloud/campaign": {
"title": "Ad Campaign Details",
"$ref": "https://ns.adobe.com/experience/adcloud/campaign",
"description":
"Adobe AdCloud ad campaign hierarchy details."
"description": "Adobe AdCloud ad campaign hierarchy details."
},
"https://ns.adobe.com/experience/adcloud/inventory": {
"title": "Ad Inventory Details",
"$ref": "https://ns.adobe.com/experience/adcloud/inventory",
"description":
"Adobe AdCloud inventory details."
"description": "Adobe AdCloud inventory details."
},
"https://ns.adobe.com/experience/adcloud/advertisement": {
"title": "Ad Asset Details",
"$ref": "https://ns.adobe.com/experience/adcloud/advertisement",
"description":
"Digital advertisement details"
"description": "Digital advertisement details"
}
}
}
},
"allOf": [
{
"$ref": "https://ns.adobe.com/xdm/context/experienceevent#/definitions/experienceevent"
"$ref":
"https://ns.adobe.com/xdm/context/experienceevent#/definitions/experienceevent"
},
{
"$ref": "#/definitions/experienceevent"
Expand Down
5 changes: 3 additions & 2 deletions extensions/adobe/experience/adcloud/inventory.example.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"xdm:segment": {
"xdm:attributablePartnerId": "13",
"xdm:attributableSegmentId": "123445",
"xdm:segments": "AbbKlvGfgVH7WK2TH6jd,5lmd4aQCvvrv1yIhjlLQ,9uGk1eYROeHVWiGAOR4p"
"xdm:segments":
"AbbKlvGfgVH7WK2TH6jd,5lmd4aQCvvrv1yIhjlLQ,9uGk1eYROeHVWiGAOR4p"
}
}
}
17 changes: 11 additions & 6 deletions extensions/adobe/experience/adcloud/inventory.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,34 +17,39 @@
"title": "Session ID",
"type": "string",
"description":
"Session ID associated with experience event, used to stitch together independent events which occurred in the same session."
"Session ID associated with experience event, used to stitch together independent events which occurred in the same session."
},
"xdm:feedId": {
"title": "Feed ID",
"type": "string",
"description": "Composite id of the publisher, ad exchange, and other features."
"description":
"Composite id of the publisher, ad exchange, and other features."
},
"xdm:sspPartnerCode": {
"title": "SSP Partner Code",
"type": "string",
"description": "The partner (exchange) through which AdCloud receives the inventory opportunity."
"description":
"The partner (exchange) through which AdCloud receives the inventory opportunity."
},
"xdm:siteId": {
"title": "Site ID",
"type": "string",
"description": "Identifier for the web site where ad impression was served."
"description":
"Identifier for the web site where ad impression was served."
},
"xdm:costCurrency": {
"title": "Cost Currency",
"type": "string",
"examples": ["USD", "EUR"],
"pattern": "^[A-Z]{3}$",
"description": "The ISO 4217 currency code used to pay partner for in ad opportunity."
"description":
"The ISO 4217 currency code used to pay partner for in ad opportunity."
},
"xdm:inventorySourceId": {
"title": "Inventory Source ID",
"type": "string",
"description": "The id of the AdCloud inventory source this opportunity was delivered on."
"description":
"The id of the AdCloud inventory source this opportunity was delivered on."
},
"xdm:segment": {
"title": "Segmentation Details",
Expand Down
5 changes: 3 additions & 2 deletions extensions/adobe/experience/adcloud/segment.example.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"xdm:attributablePartnerId": "13",
"xdm:attributableSegmentId": "123445",
"xdm:segments": "AbbKlvGfgVH7WK2TH6jd,5lmd4aQCvvrv1yIhjlLQ,9uGk1eYROeHVWiGAOR4p"
}
"xdm:segments":
"AbbKlvGfgVH7WK2TH6jd,5lmd4aQCvvrv1yIhjlLQ,9uGk1eYROeHVWiGAOR4p"
}
8 changes: 5 additions & 3 deletions extensions/adobe/experience/adcloud/segment.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,19 @@
"title": "Attributable Partner ID",
"type": "string",
"description":
"The segment provider who owns the attributableSegmentId."
"The segment provider who owns the attributableSegmentId."
},
"xdm:attributableSegmentId": {
"title": "Attributable Segment ID",
"type": "string",
"description": "The single segment accredit for user targeting among all the segments in the placement's targeting rule for the purposes of tracking costs and paying partners."
"description":
"The single segment accredit for user targeting among all the segments in the placement's targeting rule for the purposes of tracking costs and paying partners."
},
"xdm:segments": {
"title": "Segments",
"type": "string",
"description": "The intersection of the user segments that both: a) the user belonged to, and b) the ad was targeting. NOT the full list of segments that the user belonged to at the time of the auction."
"description":
"The intersection of the user segments that both: a) the user belonged to, and b) the ad was targeting. NOT the full list of segments that the user belonged to at the time of the auction."
}
}
}
Expand Down
Loading