-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(colorloupe): migrate to s2 drop-shadow tokens #3301
feat(colorloupe): migrate to s2 drop-shadow tokens #3301
Conversation
🦋 Changeset detectedLatest commit: 1749019 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Deployed on https://pr-3301--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.29 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
8c4dd4d
to
e2b901a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Seems like it was a really simple migration- we probably won't get many of those! 😆
Maybe it's just a weird, rendering thing on my end, but does the docs color loupe not have the opacity checkerboard, while the default story does? The markup certainly looks identical to me (I ran it through diffchecker), but I don't know why the checkerboard isn't rendering on the docs instance.
The docs color loupe just seems to behave a little differently to me, even when I change the stroke/stroke width on the svgs:
I see both of these locally and in the PR preview. Any ideas for that? I'm not sure if that's something that would block the approval. 🤷♀️ I don't think I see either one of these issues on production so...maybe it's just an old bug. I'm approving anyways!
--spectrum-colorloupe-outer-border-width: var(--spectrum-color-loupe-outer-border-width); | ||
--spectrum-colorloupe-inner-border-width: var(--spectrum-color-loupe-inner-border-width); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we let design know that there's just a typo in the Border section of the tokens file? I think the second color-loupe-outer-border
(which is supposed to be transparent black 200) is meant to say color-loupe-inner-border
. Do they want to update and correct that?
@marissahuysentruyt This is a known bug that I just noticed in Jira earlier today when I was looking for the design verification ticket! https://jira.corp.adobe.com/browse/CSS-775 It looks like it got closed out because it couldn't be reproduced, but I'm seeing it too in Chrome and Firefox with the url that points to the main branch, so it might need to be resurrected!
|
e2b901a
to
9200791
Compare
Description
Migrates color loupe to Spectrum 2 tokens. According to the S2 token spec and S2 components changelog for color loupe, the only updated tokens concern the drop shadow. Color loupe now uses the new drop shadow tokens
drop-shadow-elevated-x
,drop-shadow-elevated-y
,drop-shadow-elevated-blur
, anddrop-shadow-elevated-color
rather than specific color loupe tokens.CSS-707
S1 Guidelines: https://spectrum.adobe.com/page/color-loupe/
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
@marissahuysentruyt
components/colorloupe/index.css
that the color loupe component for S2 is using the tokens listed in the S2 token specspectrum-ColorLoupe
class if needed) and confirm that tokens, especially changed tokens, appear to match the S2 token specsRegression testing
Validate:
Screenshots
To-do list