-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(button): custom storybook docs from spectrum-two #3069
Conversation
|
🚀 Deployed on https://pr-3069--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.10 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not review these parts of the documentation you added in #2600, so this is my first time really looking over it! The custom .mdx template seems really necessary here to keep everything organized, and I really like what you've done with the templates to display the different groupings and variants of buttons, they feel really efficient and easy to reason through.
I left a couple of questions/opinionated suggestions that don't necessarily require changes and wouldn't necessarily hinder approval/merge. Otherwise, this looks great!
Moves over custom Button documentation from the spectrum-two branch, and integrates it with the story setup in main. As part of the effort to migrate the docs site to Storybook.
c9d1811
to
4f71a63
Compare
Description
Moves over custom Button documentation from the
spectrum-two
branch, and integrates it with the current organization of stories inmain
. As part of the effort to migrate the docs site to Storybook. Includes a custom.mdx
file, additional docs-only stories, and some supporting templates.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
To-do list