-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): add additional metadata for mapping to improve map paths #2935
Conversation
|
🚀 Deployed on https://pr-2935--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.63 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! This resolve the source map errors you mentioned. 🎉
I don't think this is on our end, but I do see these warnings as well (on main and this branch):
Sourcemap for "/virtual:/@storybook/builder-vite/setup-addons.js" points to missing source files
Sourcemap for "/virtual:/@storybook/builder-vite/vite-app.js" points to missing source files
Is this anything we'd need to address in the future? Either way, I don't think they are blocking this from merging, so approved!
Yes! I looked into that earlier and found this is a known bug: storybookjs/storybook#28567. It doesn't impact the rendering so I thought we were okay to stay at this version of Vite instead of rolling back. |
e1d2104
to
6754b51
Compare
6754b51
to
79e67f4
Compare
Description
After adding
@spectrum-css/typography
imports to Storybook, we started seeing:in the console which reflects an invalid path being used in the sourcemap files generated by the component-builder. This fix improves the path generated and removes the error messaging from our Storybook build.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
yarn build
.yarn start
To-do list