-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have option to specify gitops path where to place generated files #61
Conversation
@arturo-skydio thank you for the contribution! mind signing the CLA? |
@michaelschiff I thought I did, |
@michaelschiff sorry, was a bit impatient with opening up the other PR, looks like the CLA is green now, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. No issue with the change. But there are couple issues that need to be addressed before we can merge:
- You might want to add another test case into the e2e_test. Right now we rely on
cloud
directory being default. For example you can add anotherk8s_deploy
target alongsiderelease
andcanary
targets and update the script. Don't forget to update the.gitignore
file too. cloud
also is hardcoded in couple places ( 1, 2 ) in the GitOps PRs tool.
Sounds good, thanks for taking a look, I'll add the test |
d75ee57
to
3f96d03
Compare
@kzadorozhny Added a test for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Please address one comment and I'll merge it.
3f96d03
to
49505be
Compare
Description
Currently, gitops files get generated under a hardcoded prefix path of cloud, need a way to have a variable input for this
Related Issue
#60
Motivation and Context
For repositories that do not want gitops files generated at
cloud
path, this change is neededHow Has This Been Tested?
Just started using this and verified that no gitops_path renders gitops files in usual
cloud
directory, while specifying path correctly changes the prefix pathTypes of changes
Checklist: