correct handling of deps runtimes #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+use dict {"name": ":image" } or [ ":image" ] for images parameter
+more tests
apesternikov
force-pushed
the
ap/push_info_in_inages
branch
from
fcae250 to
4f2ee03
Compare
kzadorozhny
reviewed
Nov 28, 2022
| if not native.existing_rule(rule_name + name_suffix): | ||
| k8s_container_push( | ||
| name = rule_name + name_suffix, | ||
| image = image, | ||
| image = image_label, # buildifier: disable=uninitialized |
There was a problem hiding this comment.
Does the warning goes away if we handle the result of the image = images[image_name] statement?
There was a problem hiding this comment.
not really, somehow it reacts to the left side which is not actually a variable
kzadorozhny
reviewed
Nov 28, 2022
skylib/push.bzl
Outdated
| mnemonic = "CopyFile", | ||
| progress_message = "Copying files", | ||
| use_default_shell_env = True, | ||
| execution_requirements = {"no-remote": "1", "no-cache": "1"}, |
There was a problem hiding this comment.
Why the no-cache parameter required here?
There was a problem hiding this comment.
it is not really required but it is more efficient to locally copy file (which may come from the cache) rather than talk to remote cache.
kzadorozhny
reviewed
Nov 28, 2022
kzadorozhny
approved these changes
Nov 28, 2022
kzadorozhny
previously approved these changes
Nov 28, 2022
kzadorozhny
approved these changes
Nov 28, 2022
arturo-skydio
pushed a commit
to Skydio/rules_gitops
that referenced
this pull request
Oct 5, 2023
* +use images or image pushes in k8s_deploy images parameter
+use dict {"name": ":image" } or [ ":image" ] for images parameter
+more tests
* correct handling of dependency runtimes
* test fixes
* use template to generate expected file
* cleanup
* buildifier
* buildifier nit
* explain execution_requirements rationale
* buildifier
Co-authored-by: Konstantin Zadorozhny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: