Clean up div after component is unmounted #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix web components that are mounted into a
container
so that they clean up thediv
that they create.Description
Remove the
div
that is created when the web component in unmountedRelated Issue
#11
Motivation and Context
I have a case where I am mounting/unmounting a component (popover) and the
div
s are piling up.How Has This Been Tested?
See the test that I added in the PR to detect this. It fails without my change to
WebComponent
Types of changes
Checklist: