Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up div after component is unmounted #12

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

cuberoot
Copy link
Contributor

Fix web components that are mounted into a container so that they clean up the div that they create.

Description

Remove the div that is created when the web component in unmounted

Related Issue

#11

Motivation and Context

I have a case where I am mounting/unmounting a component (popover) and the divs are piling up.

How Has This Been Tested?

See the test that I added in the PR to detect this. It fails without my change to WebComponent

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] I have signed the Adobe Open Source CLA.
  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

@alexmirea
Copy link

Thanks for the contribution @cuberoot

@alexmirea alexmirea merged commit f938ad2 into adobe:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants