Centralize S2 icon wrapper #7113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
commented
Sep 27, 2024
| return (props: IconProps) => { | ||
| let ref = useRef<SVGElement>(null); | ||
| let ctx; | ||
| // TODO: remove this default once we release RAC and use DEFAULT_SLOT. |
There was a problem hiding this comment.
Copied from old transformer. We should actually change this but not right before release.
## API Changes
@react-spectrum/s2/@react-spectrum/s2:createIcon+createIcon {
+ Component: ComponentType<SVGProps<SVGSVGElement>>
+ context: Context<ContextValue<IconContextValue, SVGElement>>
+ returnVal: undefined
+} |
reidbarber
approved these changes
Sep 27, 2024
dannify
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized we had a bug in the S2 icon transformer: it generated imports for SkeletonWrapper and useSkeletonIcon internal utilities that weren't exported, so couldn't be used in custom icons. Instead of exporting these, I added a single
createIconhelper function that centralizes all of the icon logic in one place. This has the benefit that we export fewer internals, and also reduces bundle size since we aren't duplicating the same code in every icon.