Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix macro import in codemod output #7112

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix macro import in codemod output #7112

merged 2 commits into from
Sep 27, 2024

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Sep 27, 2024 •
edited
Loading

Users of the codemod won't have our recast patch installed, so this does a regex replace on the codemod output to update assert to with for the style macro imports.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Sep 27, 2024

Build successful! 🎉

@rspbot
Copy link

rspbot commented Sep 27, 2024

Build successful! 🎉

@reidbarber reidbarber added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 9a60dca Sep 27, 2024
29 checks passed
@reidbarber reidbarber deleted the fix-macro-import-codemod branch September 27, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihuiliao yihuiliao yihuiliao approved these changes

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reidbarber @rspbot @devongovett @yihuiliao