Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SB7] Move deprecated argTypes.defaultValue to args (Tooltip & Popover) #6387

Merged
merged 2 commits into from
May 16, 2024

Conversation

sookmax
Copy link
Contributor

@sookmax sookmax commented May 15, 2024

I've noticed SB7 deprecated the use of argTypes.defaultValue, and it encourages users to use args instead.

This PR only contains Popover and Tooltip stories as these were the one contained in #5936.

However, a quick search shows that there are several other stories (dnd.stories.tsx, Button.stories.tsx, etc) also make use of argTypes.defaultValue (just wanted to bring awareness of this).

Related Storybook resources on this matter

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@yihuiliao
Copy link
Member

GET_BUILD

@yihuiliao yihuiliao merged commit b294de8 into adobe:main May 16, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants