-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"colorSpace" key does not work when written in camel-case #190
Labels
bug
Something isn't working
Comments
skylerknight
changed the title
"colorSpace" key does not work when written in camel-case v1.0.0-alpha.13
"colorSpace" key does not work when written in camel-case
Dec 10, 2022
Agreed, we should probably standardize on either "colorspace" or "color space" (and I'm leaning toward 2 words, so camel case, as you've suggested @skylerknight.
|
This is a good call out. Camel case would be consistent with other parameters. |
GarthDB
added a commit
that referenced
this issue
Dec 11, 2022
BREAKING CHANGE: It could be considered a typo, but it will be a breaking change for anyone using leonard previously.
2 tasks
GarthDB
added a commit
that referenced
this issue
Mar 14, 2024
BREAKING CHANGE: It could be considered a typo, but it will be a breaking change for anyone using leonard previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Color space is not set when using camel-case
colorSpace
, but works when using all lowercasecolorspace
In the documentation code snippets, it shows as camel-case.
Expected behavior
I feel like it should be using camel-case, similar to
colorKeys
OR the code snippets should be changed to match.Not sure if this was already fixed in later versions. But leaving a note just in case.
Screenshots
Leonardo package and version
@leonardo-contrast-colors version: 1.0.0-alpha.13
Environment
The text was updated successfully, but these errors were encountered: