-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow webpack configuration to be customized per project #641
Comments
This is a fairly simple extension point that depends upon a statically named file hlx.webpack.customize.js. This is expected to export a default function that accepts the hedy config and the webpack config and returns the webpack config.
what exactly is your use case? I think that replacing the entire webpack config is probably not very helpful, as it contains many internal logic. |
My (current) use case is adding a plugin which addresses compatibility issues between webpack-bundled code and opentelemetry-js (elastic/require-in-the-middle#35 describes the problem although the plugin code in that issue is quite outdated and isn't directly applicable for a variety of reasons). It is certainly plausible to have an extension point that only does this (if this is deemed too much of a footgun), but I was aiming for something that didn't have to be revisited later. |
This is a fairly simple extension point that depends upon a statically named file hlx.webpack.customize.js. This is expected to export a function named extraPlugins that accepts the hedy config and the webpack config and returns an array of plugins. This is an alternative to adobe#642 which provides a narrower extension point.
🎉 This issue has been resolved in version 10.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Expected Behaviour
There should be a way to customize the webpack configuration used by helix-deploy, e.g. to add plugins.
Actual Behaviour
There isn't :(
Reproduce Scenario (including but not limited to)
I have a use case where I need to modify the webpack-bundled code to add instrumentation. The task can be done with a webpack plugin although there's no place (at least that I can see) to inject that into the webpack config.
Steps to Reproduce
Platform and Version
Sample Code that illustrates the problem
Logs taken while reproducing problem
The text was updated successfully, but these errors were encountered: