fix: don't respond when headers already sent #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a patch release when merged. |
tripodsan
commented
Nov 17, 2023
Comment on lines
+86
to
+88
| if (res.headersSent) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
this is the actual fix: if serving a local file failed due to a communication error, the response was already initiated but it tried later to serve the proxied resource as well.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2278 +/- ##
==========================================
+ Coverage 93.43% 93.49% +0.05%
==========================================
Files 26 26
Lines 3594 3611 +17
Branches 1 1
==========================================
+ Hits 3358 3376 +18
+ Misses 236 235 -1 ☔ View full report in Codecov by Sentry. |
dominique-pfister
approved these changes
Nov 17, 2023
|
🎉 This PR is included in version 16.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2276