Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEM_NO_OPEN not working #2323

Closed
flx-sta opened this issue Mar 6, 2024 · 5 comments · Fixed by #2324
Closed

AEM_NO_OPEN not working #2323

flx-sta opened this issue Mar 6, 2024 · 5 comments · Fixed by #2324
Assignees
Labels
bug Something isn't working released

Comments

@flx-sta
Copy link

flx-sta commented Mar 6, 2024

Description
When using a .env file and adding the variable AEM_NO_OPEN it doesn't seem to be recognized.
I tried:

AEM_NO_OPEN=TRUE
AEM_NO_OPEN=true
AEM_NO_OPEN='TRUE'
AEM_NO_OPEN='true'
AEM_NO_OPEN="TRUE"
AEM_NO_OPEN="true"

To Reproduce
Steps to reproduce the behavior:

  1. Have an EDS project ready
  2. Have the cli ready
  3. Create a .env file in the root of your repo
  4. Add AEM_NO_OPEN=true to your .env file
  5. run aem up in your terminal

Expected behavior
The browser doesn't open a page automatically

Version:
16.1.5

@flx-sta flx-sta added the bug Something isn't working label Mar 6, 2024
@flx-sta flx-sta changed the title AEM_NO_OPEN not working AEM_NO_OPEN not working Mar 6, 2024
@tripodsan
Copy link
Contributor

indeed....strange ;-) thanks for reporting.

@tripodsan tripodsan self-assigned this Mar 6, 2024
@flx-sta
Copy link
Author

flx-sta commented Mar 6, 2024

@tripodsan I found this

AEM_OPEN=false

and this works like a charm.

So either the documentation is off or something else

tripodsan added a commit that referenced this issue Mar 7, 2024
tripodsan pushed a commit that referenced this issue Mar 7, 2024
## [16.2.10](v16.2.9...v16.2.10) (2024-03-07)

### Bug Fixes

* ensure that AEM_NO_OPEN works as expected ([#2324](#2324)) ([c985c13](c985c13)), closes [#2323](#2323)
@tripodsan
Copy link
Contributor

🎉 This issue has been resolved in version 16.2.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@flx-sta
Copy link
Author

flx-sta commented Mar 7, 2024

@tripodsan thanks for the quick fix 🚀
Just tested it and works like a charm.

One small detail: There seem to be some console.log in src/up.js L 105+. Are they supposed to be there?

      console.log('   open', argv.open);
      console.log('no-open', argv.noOpen);
image

@tripodsan
Copy link
Contributor

One small detail: There seem to be some console.log in src/up.js L 105+. Are they supposed to be there?

oops... thanks you for catching !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants