fix(cache): proper root filename handling for subfolders (#2305)

adobe · Jan 25, 2024 · e7e2d34 · e7e2d34
1 parent 2fe8f7f
commit e7e2d34
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/server/utils.js b/src/server/utils.js
@@ -139,7 +139,10 @@ window.LiveReloadOptions = {
   computePathForCache(url, directory) {
     const u = new URL(url);
     const { pathname, search } = u;
-    let fileName = pathname.substring(1) || 'index.html';
+    let fileName = pathname.substring(1);
+    if (fileName.endsWith('/') || fileName === '') {
+      fileName += 'index.html';
+    }
     if (search) {
       let qs = search.substring(1); // remove leading '?'
       if (fileName.length + qs.length > 255) {

diff --git a/test/server-utils.test.js b/test/server-utils.test.js
@@ -205,6 +205,8 @@ describe('Utils Test', () => {
 
   describe('Cache', () => {
     it('compute path for cache', () => {
+      assert.equal(utils.computePathForCache('https://www.sample.com/', '/target/'), path.resolve('/target', 'index.html'));
+      assert.equal(utils.computePathForCache('https://www.sample.com/folder/', '/target/'), path.resolve('/target/folder', 'index.html'));
       assert.equal(utils.computePathForCache('https://www.sample.com/index.html', '/target/'), path.resolve('/target', 'index.html'));
       assert.equal(utils.computePathForCache('https://www.sample.com/folder/index.html', '/target/'), path.resolve('/target', 'folder/index.html'));
       assert.equal(utils.computePathForCache('https://www.sample.com/script.js', '/target/'), path.resolve('/target', 'script.js'));