Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Sprint -> Release #8680

Merged
merged 2 commits into from
Sep 9, 2014
Merged

Sprint -> Release #8680

merged 2 commits into from
Sep 9, 2014

Conversation

marcelgerber
Copy link
Contributor

For #7828 and https://trello.com/c/atMTdx6l/1313-brackets-7828-should-be-consistent-about-release-vs-sprint-issue

Replaces most of the occurences of Sprint with Release, maybe even too many.

The only ones I left in place were some unit tests and the non-English translations (to be translated).

@@ -403,7 +403,7 @@ define({
"RELAUNCH_CHROME" : "Relaunch Chrome",
"ABOUT" : "About",
"CLOSE" : "Close",
"ABOUT_TEXT_LINE1" : "sprint {VERSION_MINOR} {BUILD_TYPE} {VERSION}",
"ABOUT_TEXT_LINE1" : "release {VERSION_MAJOR}.{VERSION_MINOR} {BUILD_TYPE} {VERSION}",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be uppercase?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it should be "Release".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@redmunds
Copy link
Contributor

redmunds commented Aug 6, 2014

@marcelgerber Thanks for looking at this. There is a similar grunt set-sprint task in the brackets-shell repo that updates several more files that needs to be updated also.

@peterflynn
Copy link
Member

@ingorichter Does this have any implications with how builds are deployed on brackets.io or the update-notification server?

@marcelgerber
Copy link
Contributor Author

@redmunds They don't depend on each other, do they? I'm not super used to brackets-shell, and we need another PR there anyway. The trello card linked above mentions some other changes to be done there as well.

@peterflynn Probably not. They already use names like "Release 0.xx" and don't depend on the changes here (which are a Grunt task rename and a UI string change).
The task rename will break automated scripts depending on that task, though.

@ingorichter
Copy link
Contributor

@peterflynn No, the information for brackets.io is coming from the update notifications. These changes won't break any deployment of new builds.

@redmunds
Copy link
Contributor

@marcelgerber We definitely want to update both brackets and brackets-shell, so might as well do them together. Take a look at this pull request to see the files that are updated. They are all data files, so it should be straight forward.

@marcelgerber
Copy link
Contributor Author

@ingorichter
Copy link
Contributor

I'm going to merge #8680 and adobe/brackets-shell#462 after the release of 43. I need to make small breaking changes to the build machine setup.

@ingorichter ingorichter self-assigned this Aug 27, 2014
@redmunds
Copy link
Contributor

@ingorichter Since you are looking at this, you should take the "Run grunt set-sprint --sprint=N to update sprint number in master branches" task to use as a test.

@redmunds redmunds mentioned this pull request Sep 2, 2014
ingorichter added a commit that referenced this pull request Sep 9, 2014
@ingorichter ingorichter merged commit 0f21bf6 into adobe:master Sep 9, 2014
@ingorichter
Copy link
Contributor

Thanks @marcelgerber

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants