Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Update strings.js for Persian language #5827

Merged
merged 4 commits into from
Nov 4, 2013
Merged

Conversation

myaaghubi
Copy link
Contributor

Please merge this change

@marcelgerber
Copy link
Contributor

In root/strings.js, we shouldn't have persian chars.

@ghost ghost assigned couzteau Nov 4, 2013
@couzteau
Copy link
Member

couzteau commented Nov 4, 2013

Thanks Mohammad. I have used google translate to review, which is of course very limited in quality. Would you happen to know a developer with a github account to review your translations? That would be great!

I will merge this for now, but moving forward it would be great if we would have a human reviewer for translation chnages.

@@ -455,7 +455,7 @@ define({
"LOCALE_IT" : "Italian",
"LOCALE_JA" : "Japanese",
"LOCALE_NB" : "Norwegian",
"LOCALE_FA_IR" : "Persian",
"LOCALE_FA_IR" : "Persian-Farsi",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have been wondering wether it be Persian, Farsi or Persian-Farsi.

couzteau added a commit that referenced this pull request Nov 4, 2013
Update strings.js for Persian language
@couzteau couzteau merged commit e9c7913 into adobe:master Nov 4, 2013
@myaaghubi
Copy link
Contributor Author

Thanks Jochen. Unfortunately, open source software is not common in my country, therefore I do not know anyone with a github account to review my translation.
Persion is Latin name of Farsi ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants