This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix #5770: Replace with $1 and so on works in Replace All mode, too #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See my version in #5772. I slightly prefer maintaining the original |
| @@ -468,7 +474,7 @@ define(function (require, exports, module) { | |||
| .reverse() | |||
| .forEach(function (checkedRow) { | |||
| var match = results[$(checkedRow).data("match")], | |||
| rw = typeof replaceWhat === "string" ? replaceWith : replaceWith.replace(/\$(\d)/g, replaceFunction); | |||
| rw = typeof replaceWhat === "string" ? replaceWith : replaceWith.replace(/\$(\d)/g, function (w, i) { return match.match[i]; }); | |||
There was a problem hiding this comment.
I don't like the shadowing of "match" here--I chose a different name for the outer variable for this reason.
|
Closed as #5772 (the better one) was merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5770, where regexp replace works incorrectly while in Replace All mode.
My question: Is there anything better than a do-while loop with an if to break (there must be anything better ;) )
@njx