Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Update LESS -> 2.5.1 #10240

Merged
merged 3 commits into from
Sep 13, 2015
Merged

Update LESS -> 2.5.1 #10240

merged 3 commits into from
Sep 13, 2015

Conversation

marcelgerber
Copy link
Contributor

This is a major update of LESS, including breaking changes. So watch out for broken extensions!

LESS 1.7.5 -> 2.5.1

https://github.com/less/less.js/blob/master/CHANGELOG.md#251

@marcelgerber
Copy link
Contributor Author

I don't think it contains fixes we actually need in Brackets. I'd like to get basic review first as we can still update LESS later.

@marcelgerber marcelgerber changed the title [REVIEW ONLY] Update LESS -> 2.1.1 [REVIEW ONLY] Update LESS -> 2.2.0 Jan 4, 2015
@marcelgerber
Copy link
Contributor Author

Updated LESS to 2.2.0

@marcelgerber
Copy link
Contributor Author

There are only two extensions using less directly:

@MiguelCastillo
Copy link
Contributor

Let's merge it in... I will work through any regressions in Themes. Thanks for the heads up!

@marcelgerber marcelgerber changed the title [REVIEW ONLY] Update LESS -> 2.2.0 [REVIEW ONLY] Update LESS -> 2.3.1 Feb 5, 2015
@marcelgerber
Copy link
Contributor Author

Updated LESS to 2.3.1

@abose abose added this to the Release 1.4 milestone Apr 15, 2015
@humphd humphd mentioned this pull request May 22, 2015
Closed
@abose
Copy link
Contributor

abose commented Jun 18, 2015

Risky at this stage. Moving to 1.5
@marcelgerber Will merge this just after release 1.4 . Could target the latest release 2.5.1 ,

@abose abose modified the milestones: Release 1.5, Release 1.4 Jun 18, 2015
@marcelgerber marcelgerber changed the title [REVIEW ONLY] Update LESS -> 2.3.1 [REVIEW ONLY] Update LESS -> 2.5.1 Jun 19, 2015
@abose
Copy link
Contributor

abose commented Sep 11, 2015

@marcelgerber @MiguelCastillo Is this safe to merge in at this time.
We are targetting for 1.5 this month or next.

@MiguelCastillo
Copy link
Contributor

I am good merging this. @marcelgerber can we merge this one?

@FreaKzero
Copy link

Also from my side (Sorry ... i didnt response to the message in 2014) im good for the merge since im only parsing variables anyways.

Marcel Gerber added 3 commits September 13, 2015 14:15
Update LESS -> 2.5.1
70dd73d
Update grunt -> 0.4.5
67a69f2 
It should be fully backwards-compatible
Update grunt-contrib-less -> 1.0.1
16a7734 
There's not yet a published version that uses [email protected], so we use [email protected] instead
@marcelgerber
Copy link
Contributor Author

Yes, this is ready, just rebased. Waiting for Travis so I can merge.

@marcelgerber marcelgerber changed the title [REVIEW ONLY] Update LESS -> 2.5.1 Update LESS -> 2.5.1 Sep 13, 2015
marcelgerber pushed a commit that referenced this pull request Sep 13, 2015
Merge pull request #10240 from MarcelGerber/less-2
a71c8ef 
Update LESS -> 2.5.1
@marcelgerber marcelgerber merged commit a71c8ef into adobe:master Sep 13, 2015
@marcelgerber marcelgerber deleted the less-2 branch September 13, 2015 12:22
@marcelgerber
Copy link
Contributor Author

@FreaKzero @MiguelCastillo Bear in mind, though, that the public API has changed.
See the changes in this PR for what needs to be done to make it work with the new LESS version.

@core-ai-bot core-ai-bot mentioned this pull request Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@abose abose

Labels
None yet
Projects
None yet
Milestone
Release 1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@marcelgerber @MiguelCastillo @abose @FreaKzero