Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Provide a toggle menu item to switch between Live Preview implementations #10239

Closed
busykai opened this issue Dec 19, 2014 · 1 comment · Fixed by #10285
Closed

Provide a toggle menu item to switch between Live Preview implementations #10239

busykai opened this issue Dec 19, 2014 · 1 comment · Fixed by #10285

Comments

@busykai
Copy link
Contributor

busykai commented Dec 19, 2014

This is a follow-up to #10226. Manual editing of the Brackets configuration file may be cumbersome and error-prone. A much easier way to switch between the implementations is to provide a toggle menu item.

@redmunds redmunds self-assigned this Jan 6, 2015
@redmunds redmunds assigned busykai and unassigned redmunds Jan 8, 2015
busykai added a commit that referenced this issue Jan 9, 2015
The menu item is moved from Debug menu to File menu.

Also:
    - Ensure correct status changes when switching implementations.
    - Disable 'Project Settings' when multi-browser is on.
    - Minor refactor/doc changes in LiveDevelopment/main.js
busykai added a commit that referenced this issue Jan 15, 2015
PreferencesManager.on("change") was executing before AppInit.appReady().
This was causing various inconsistencies, including setting up the UI before
LiveDevelopment is actually initialized. Handling of pref change is now moved
to AppInit.appReady and the implementation is set only after the modules are
actually initialized.

Fix #10239: toggle menu to switch livedev impls.
    - Ensure correct status changes when switching implementations.
    - Disable 'Project Settings' when multi-browser is on.

Also:
    - Minor improvements to how the pref is defined.
    - Close LiveDevelopment explicitly after each test.
    - Minor refactor/doc changes in LiveDevelopment/main.js
    - Minor stylistic and documentation changes.
redmunds added a commit that referenced this issue Jan 15, 2015
@redmunds
Copy link
Contributor

Confirmed. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants