-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
This LGTM. We should get this in ASAP as this is holding LOC process. So if anyone has any suggestion please suggest ASAP. Thanks! |
tagging @marcelgerber @pthiess @ingorichter @TomMalbran @jbalsas |
"description": "CSS code hints are now available for style elements inside PHP files." | ||
}, | ||
{ | ||
"name": "Remember Linter collapsed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nethip The grammar here is wrong. Can we change to: "Remember Collapsed Linters"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
Is it worth calling out either of these patches?
|
@peterflynn Thanks for reviewing these strings. I will raise a PR with all of the changes you have suggested. About adding two more entries; we have already gone through the LOC process to get update strings for other locales. Adding these will result in running through our LOC process again, which is time consuming. Is it better to leave have these strings included in the release notes page or do we want to explicitly mention them in the update strings? |
@peterflynn Raised the PR #204 . Please review it and merge it, if it looks fine. |
No description provided.