This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 614
Fix Brackets Live Development Issues with Chrome OSX #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned redmunds
Nov 5, 2013
@fungl164 Thanks for all of your work on this. Merging. |
redmunds
added a commit
that referenced
this pull request
Nov 6, 2013
Fix Brackets Live Development Issues with Chrome OSX
@njx it feels good to give back to the community. Thank you guys putting out Brackets as well! re: "relaunch", you might also want to take a look at the _openInterstitialPage() sequence. In earlier trials I had a small patch which removed the need to reconnect the Inspector object using timeouts. For simplicity purposes, I took it out for this part, so it hasn't been tested well enough. |
@njx Done. I updated Client & Server Smokes, and How to Use Brackets. |
Thanks. I wonder if we should mention in How to Use Brackets that we open a separate Chrome instance. Also, in the smoke tests, would it make sense to actually have the tester double-check that Chrome was opened in a separate profile? |
redmunds
added a commit
that referenced
this pull request
Dec 8, 2015
Fix Brackets Live Development Issues with Chrome OSX
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides better real-time detection/separation of Chrome debug sessions, as well as better connectivity + window/tab management from within Brackets.