Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Fix Brackets Live Development Issues with Chrome OSX #371

Merged
merged 1 commit into from
Nov 6, 2013

Conversation

fungl164
Copy link
Contributor

@fungl164 fungl164 commented Nov 5, 2013

This provides better real-time detection/separation of Chrome debug sessions, as well as better connectivity + window/tab management from within Brackets.

@redmunds
Copy link
Contributor

redmunds commented Nov 6, 2013

@fungl164 Thanks for all of your work on this. Merging.

redmunds added a commit that referenced this pull request Nov 6, 2013
Fix Brackets Live Development Issues with Chrome OSX
@redmunds redmunds merged commit 305dadc into adobe:master Nov 6, 2013
@njx
Copy link

njx commented Nov 6, 2013

SO AWESOME. Thanks @fungl164!

@redmunds, we should probably look around the various docs to find references to the "relaunch" dialog and remove them. The smoke tests are the main one that comes to mind, but there might be references in Getting Started, How to Use Brackets, etc.

@fungl164
Copy link
Contributor Author

fungl164 commented Nov 6, 2013

@njx it feels good to give back to the community. Thank you guys putting out Brackets as well!

re: "relaunch", you might also want to take a look at the _openInterstitialPage() sequence. In earlier trials I had a small patch which removed the need to reconnect the Inspector object using timeouts. For simplicity purposes, I took it out for this part, so it hasn't been tested well enough.

@redmunds
Copy link
Contributor

redmunds commented Nov 7, 2013

@njx Done. I updated Client & Server Smokes, and How to Use Brackets.

@njx
Copy link

njx commented Nov 7, 2013

Thanks. I wonder if we should mention in How to Use Brackets that we open a separate Chrome instance.

Also, in the smoke tests, would it make sense to actually have the tester double-check that Chrome was opened in a separate profile?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants