Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

check thirdparty ws library in to repo #209

Merged
merged 2 commits into from
Feb 22, 2013
Merged

Conversation

joelrbrandt
Copy link
Contributor

We decided it would be easier to simply check our distribution of "ws" (the WebSocket library) in to the repo. (In the past, we used npm to bootstrap this in the setup.sh script)

This pull adds the library and removes the bootstrapping code from setup.sh.

@ghost ghost assigned jasonsanjose Feb 22, 2013
@jasonsanjose
Copy link
Member

Seems reasonable. I don't know the history of your websocket fork though, though I read the README. Is that all I need to know?

In the future, we could still use npm install for dependencies. I didn't realize you were using the bundled node executable to do the install. There's a package.json file now at the top of this repo that we use for grunt dependencies currently. Could be an option for other deps later?

@joelrbrandt
Copy link
Contributor Author

Yes, the README has everything you need to know. I just updated it to provide a little bit more detail on how this module was made. Here's the text I added:

Specifically, this module was made by following these steps:

  1. Start with version 0.4.25 of ws
  2. Incorporate options.js directly into ws and fix up paths
  3. Remove files not needed for deployment (tests, etc.)
  4. Remove "compiled" code, and fix up paths to use "fallback" JS code by default. (Removing "compiled" code makes it easier to have this work in a cross-platform way.)

Yes, in the future we can still use ``npm install` for dependencies. In fact, I'm planning to write a script today that installs and then runs node-inspector to help with debugging node code. That will use the same process as the "bootstrapping" code that was removed in this pull.

@jasonsanjose
Copy link
Member

Merging.

But I think instead of the boostrapping in download_deps.sh I think we should try to use the devDependencies specified in package.json like we use for grunt. Those deps should only be installed in our dev env anyhow right? Maybe I'm missing something, but I'm looking for more excuses to move away from our shell scripts and into grunt and npm.

jasonsanjose added a commit that referenced this pull request Feb 22, 2013
check thirdparty ws library in to repo
@jasonsanjose jasonsanjose merged commit c6efa50 into master Feb 22, 2013
@jasonsanjose jasonsanjose deleted the jrb/bring-ws-into-repo branch February 22, 2013 21:21
jasonsanjose added a commit that referenced this pull request Dec 8, 2015
check thirdparty ws library in to repo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants