Fix loop in Propositions SPA sandbox page #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every time the useSendPageViewEvent() function was being called without the xdm and data params being specified, the default parameter would create a new object. This would make the function run again aka it was not safe to call multiple times because the data and xdm variables didn't pass the === test. Since the values are small, there isn't much worry about performance. See this comment about the subject: facebook/react#14476 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deep compare
dataandxdmin theuseSendPageViewEvent()hook. Ifdataandxdmare not passed in, a new object is created which doesn't pass the===test, causing the function to run again even though there are no real changes. Instead, we deeply compare them between runs. The performance hit should be minimal because they are small objects.Related Issue
Fixes #1005
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: