Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : Space issues on the return flow #1628

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix : Space issues on the return flow #1628

merged 1 commit into from
Nov 5, 2024

Conversation

BaskarMitrah
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

timkim
timkim approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@timkim timkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepessh noted that were some failing tests but I think it's because those tests are a bit outdated.

@timkim timkim merged commit 1cd0ea1 into main Nov 5, 2024
2 of 3 checks passed
@timkim timkim deleted the fix/space-issue branch November 5, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timkim timkim timkim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BaskarMitrah @timkim