Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with Publishing section #12

Closed
shazron opened this issue Aug 31, 2020 · 1 comment · Fixed by #22
Closed

Update README with Publishing section #12

shazron opened this issue Aug 31, 2020 · 1 comment · Fixed by #22
Assignees

Comments

@shazron
Copy link
Member

shazron commented Aug 31, 2020

File: https://github.com/adobe/gatsby-theme-parliament/blob/main/README.md

@shazron shazron self-assigned this Aug 31, 2020
@shazron
Copy link
Member Author

shazron commented Sep 6, 2020

This will contain:

  1. The Pull Request approval flow
  • label: deploy or deploy:dev
  • PR has to be approved
  • PR branch needs to be on same repo (GH security restriction)
  1. GH Actions: Site Build: for the GH Contributors component:
  • need to standardize on main branch (not master)
  • src/pages based off the root of the repo (so we don't set the REPO_ROOT env var)
  • set the appropriate env vars as specified in the README
  1. GH Actions: Site Build: for the Feedback component:
  • set an Org secret for the GATSBY_LAUNCH_URL
  1. GH Actions: Azure Blob Storage Deployment:
  • set Org secrets for all the Azure Storage connection string for both Prod and Dev
  • Azure Container name will just be the repo name (Azure Blob Storage Container is analogous to Folder in S3)
  1. GH Actions: Github Pages Deployment:
  • no change, except for the new env vars for the 2 components for a Site Build, see above
  1. After successful deployment, post a PR comment showing the Azure Static Website Url
  2. Update our CDN with the proper mapping to this Azure Static Website Url (needs to be done only once). This is a manual process.

shazron added a commit that referenced this issue Sep 15, 2020
shazron added a commit that referenced this issue Sep 15, 2020
icaraps pushed a commit that referenced this issue Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant