Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env as httpOption #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

obarcelonap
Copy link

@obarcelonap obarcelonap commented Nov 15, 2024

Description

Allows to reconfigure the events URLs to point to stage by exposing a new httpOption called env.

Related Issue

Motivation and Context

In Adobe Commerce we have appbuilder apps connected to stage environment in the developer console. Current implementation based on cliEnv forces us to hardcode the events URLs in our code base and pass them as httpOption.
Code snippet:

const eventsApi = Events.init("orgId", "apiKey", "accessToken", {
    eventsBaseURL: 'https://api-stage.adobe.io/',
    eventsIngressURL: 'https://eventsingress-stage.adobe.io/',
})

This change allows to reconfigure the URLs without the need of hardcoding them.

const eventsApi = Events.init("orgId", "apiKey", "accessToken", { env: 'stage' })

How Has This Been Tested?

Unit testing.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant