Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-16630] Full tvOS support #60

Merged
merged 6 commits into from
Jul 21, 2022
Merged

[MOB-16630] Full tvOS support #60

merged 6 commits into from
Jul 21, 2022

Conversation

addb
Copy link
Collaborator

@addb addb commented Jul 11, 2022 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Simulator Screen Shot - Apple TV - 2022-07-11 at 14 12 39

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

kevinlind and others added 2 commits April 8, 2022 20:10
@addb addb requested a review from emdobrin July 11, 2022 22:18
@codecov
Copy link

codecov bot commented Jul 11, 2022 •
edited
Loading

Codecov Report

Merging #60 (362ce56) into dev (4035411) will decrease coverage by 3.87%.
The diff coverage is n/a.

❗ Current head 362ce56 differs from pull request most recent head b4c9e36. Consider uploading reports for the commit b4c9e36 to get more accurate results

@@            Coverage Diff             @@
##              dev      #60      +/-   ##
==========================================
- Coverage   85.81%   81.94%   -3.87%     
==========================================
  Files           4        4              
  Lines         155      155              
==========================================
- Hits          133      127       -6     
- Misses         22       28       +6

@emdobrin emdobrin requested a review from cdhoffmann July 13, 2022 23:42
emdobrin
emdobrin reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@emdobrin emdobrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

.circleci/config.yml Outdated Show resolved Hide resolved
@addb addb changed the title Full tvOS support [MOB-16630] Full tvOS support Jul 18, 2022
@addb addb changed the base branch from dev to feature/tvos July 21, 2022 19:02
@emdobrin emdobrin merged commit 2cb601e into adobe:feature/tvos Jul 21, 2022
@addb addb mentioned this pull request Feb 17, 2023
Merged
10 tasks
addb added a commit that referenced this pull request Feb 21, 2023
@addb @kevinlind
Add tvOS support (#68)
e430526 
* [MOB-16630] Full tvOS support (#60)

* full tvOS support

* Update Xcode version to 13.0.0 for circleci builds

* Update core depdendency in podspec for tvOS support

* Script and typo fixes

* Update Package.swift

Co-authored-by: Kevin Lind <[email protected]>

* Update pods

* Removed duplicate functions from ExtensionRuntime class to fix the build issue (#69)

---------

Co-authored-by: Kevin Lind <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emdobrin emdobrin emdobrin approved these changes

@cdhoffmann cdhoffmann Awaiting requested review from cdhoffmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addb @emdobrin @kevinlind