Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests with AEPTestUtils and other MISC fixes #1002

Merged
merged 21 commits into from
Mar 6, 2024
Merged

Fix tests with AEPTestUtils and other MISC fixes #1002

merged 21 commits into from
Mar 6, 2024

Conversation

cdhoffmann
Copy link
Contributor

Waiting on adobe/aepsdk-testutils-ios#31 (review)

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cdhoffmann cdhoffmann requested a review from praveek February 26, 2024 19:13
praveek
praveek reviewed Feb 27, 2024
View reviewed changes
Podfile Outdated Show resolved Hide resolved
praveek
praveek reviewed Feb 27, 2024
View reviewed changes
Podfile Outdated Show resolved Hide resolved
@cdhoffmann cdhoffmann marked this pull request as ready for review March 5, 2024 21:36
@cdhoffmann cdhoffmann requested a review from praveek March 5, 2024 21:36
praveek
praveek reviewed Mar 6, 2024
View reviewed changes
AEPCore/Tests/FunctionalTests/Configuration/ConfigurationAppIDTests.swift Outdated
@@ -15,6 +15,7 @@
import XCTest
import AEPCoreMocks
import AEPServicesMocks
import AEPServicesMocks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the duplicate line?

@praveek praveek merged commit 7ae5707 into adobe:dev-v5.0.0 Mar 6, 2024
17 checks passed
@cdhoffmann cdhoffmann deleted the fixJsonTests branch March 6, 2024 18:36
@cdhoffmann cdhoffmann mentioned this pull request May 14, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveek praveek praveek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdhoffmann @praveek