Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing hobbes test #1231

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Fix failing hobbes test #1231

merged 1 commit into from
Oct 29, 2020

Conversation

bpauli
Copy link
Contributor

@bpauli bpauli commented Oct 29, 2020

@bpauli
Fix failing hobbes test
1b91cb3 
- add namespace for carousel component
- remove Facebook and Instagram test because of #1225
@bpauli bpauli requested a review from msagolj October 29, 2020 10:06
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 29, 2020 •
edited
Loading

Codecov Report

Merging #1231 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1231   +/-   ##
==============================================
  Coverage          84.76%   84.76%           
  Complexity          1761     1761           
==============================================
  Files                168      168           
  Lines               4969     4969           
  Branches             770      770           
==============================================
  Hits                4212     4212           
  Misses               302      302           
  Partials             455      455

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba50fb...1b91cb3. Read the comment docs.

@bpauli bpauli merged commit 5595d8c into development Oct 29, 2020
@bpauli bpauli deleted the issue/failing-hobbes-test branch October 29, 2020 10:42
msagolj pushed a commit that referenced this pull request Oct 29, 2020
@bpauli @msagolj
Fix failing hobbes test (#1231)
476cfc0 
- add namespace for carousel component
- remove Facebook and Instagram test because of #1225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msagolj msagolj msagolj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpauli @msagolj