Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2561: enable preview filter for category pickers #817

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Feb 3, 2022

Description

This PR enables the preview date filter for category pickers in the Page properties.

Inside a Launch and when using Timewrap, the category pickers are already preconfigured for staged catalog data. For places that are not accessible in this context, the same should be possible using a filter inside the picker itself.

Related Issue

CIF-2561

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #817 (5079cbe) into issue/CIF-2560 (fa2042d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             issue/CIF-2560     #817   +/-   ##
=================================================
  Coverage             89.54%   89.54%           
  Complexity             1842     1842           
=================================================
  Files                   313      313           
  Lines                  8233     8233           
  Branches               1241     1241           
=================================================
  Hits                   7372     7372           
  Misses                  621      621           
  Partials                240      240           
Flag Coverage Δ
integration 55.36% <ø> (ø)
jest 86.40% <ø> (ø)
karma 94.83% <ø> (ø)
unittests 89.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa2042d...5079cbe. Read the comment docs.

Base automatically changed from issue/CIF-2560 to master February 10, 2022 13:34
@herzog31 herzog31 removed their request for review March 23, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants