Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-173 add video capability #176

Merged
merged 1 commit into from
Oct 20, 2020
Merged

GH-173 add video capability #176

merged 1 commit into from
Oct 20, 2020

Conversation

npeltier
Copy link
Contributor

  • video component (no group) that outputs one video tag per breakpoint,
  • dialog that comes with it,
  • add ability to include fields in a responsive loop,
  • add video to flex that way

@npeltier
adobeGH-173 add video capability
60f10cc 
- video component (no group) that outputs one video tag per breakpoint,
- dialog that comes with it,
- add ability to include fields in a responsive loop,
- add video to flex that way
auniverseaway
auniverseaway approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@auniverseaway auniverseaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these video props probably shouldn't be responsive, but I think +1 overall.

@auniverseaway auniverseaway merged commit cc0f041 into adobe:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auniverseaway auniverseaway auniverseaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npeltier @auniverseaway