Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows on ARM #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anthony-linaro
Copy link

@anthony-linaro anthony-linaro commented Nov 13, 2024

Description

This PR adds support for Windows ARM64 platforms, alongside the others.

It also fixes a small issue in the XMPScanner code to allow it to compile properly with C++17 (auto_ptr to shared_ptr).

Related Issue

n/a (should I open one?)

Motivation and Context

An external company needs this work done, in order to have a native ARM64 version of their application.

There appears to have been semi-support for this in a previous release, looking at the CMake files, but appears to have broken with time.

How Has This Been Tested?

I have compiled and run the samples, which all appear to return valid data. If there is a more comprehensive test suite somewhere, I am happy to run that also.

All testing done locally on my Thinkpad T14s Gen6 with a Snapdragon X Elite chip.

A native VS2022 environment was used on this device.

I also added some options to the batch files available, in some cases I added the options to the end, in others I renumbered the options, where it felt more appropriate depending on the context of the menu.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

For the CLA, I am checking with my management chain regarding it. Will update once I have more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant