[MTG-294] reusing the existing code for the finalize tree with collection #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanChe
changed the title
StanChe
changed the title
programs/bubblegum/program/src/processor/finalize_tree_with_root_and_collection.rs
Outdated
Show resolved
Hide resolved
programs/bubblegum/program/src/processor/finalize_tree_with_root_and_collection.rs
Outdated
Show resolved
Hide resolved
n00m4d
approved these changes
Jul 11, 2024
|
|
||
| finalize_tree( | ||
| let mut accs: FinalizeTreeWithRoot<'info> = FinalizeTreeWithRoot { | ||
| tree_authority: ctx.accounts.tree_authority.to_owned(), |
There was a problem hiding this comment.
Those .to_owned just copy/clone underlying data each time. It might be fine, though it might be not optimal.
There was a problem hiding this comment.
How should we better do this?
programs/bubblegum/program/src/processor/finalize_tree_with_root_and_collection.rs
Outdated
Show resolved
Hide resolved
…wn the call stack
blockiosaurus
approved these changes
Jul 12, 2024
|
Great work, thank you! |
RequescoS
approved these changes
Jul 16, 2024
StanChe
merged commit 463851b
into
feature/finalize-tree-with-collection
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusing the existing code combining the validation from the mint to collection and finalize tree with root logic