Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve firmlinks so we agree with nfsd on the path #102

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

mtibben
Copy link
Contributor

@mtibben mtibben commented Oct 10, 2019

macOS Catalina's APFS uses the concept of "firmlinks" to overlay a writeable volume on a read-only volume. However when NFS addresses these firmlinked locations, it seems to be only aware of the writeable layer.

So this PR applies a similar logic to our NFS export by adding a resolveHostPath function to resolve the path to the firmlinked location. It takes a slightly naive approach by assuming if a /System/Volumes/Data/... location exists, a firmlink exists. But this seems to be a standard location in macOS Catalina now and not modifiable, so a naive approach should be fine I think.

Fixes #100

@PaulBrandt PaulBrandt mentioned this pull request Oct 10, 2019
@tonivdv tonivdv merged commit d3b1e31 into adlogix:master Oct 14, 2019
@tonivdv
Copy link
Member

tonivdv commented Oct 14, 2019

Thanks @mtibben

@gerbenvandijk
Copy link

gerbenvandijk commented Oct 22, 2019

@tonivdv @mtibben thanks for this, we are using docker-machine-nfs and had developed a similar fix initially (via our own shell script). But we are wondering, how do you deal with relative paths in docker-compose? For us - even with the mounts being fixed through the shell script - docker-compose seems to also need an absolute path at the moment.

@gerbenvandijk
Copy link

Please disregard the above, we have upgraded docker to the latest version (and also upgraded the existing docker-machine instances) and since then relative paths in docker-compose work again as expected.

Thanks btw for keeping this project alive 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS Catalina
3 participants