-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Xcode 13 beta 3 #559
Conversation
…sions. Xcode 13 beta 3 introduces a breaking change related to API unavailable for iOS extensions: https://developer.apple.com/documentation/xcode-release-notes/xcode-13-beta-release-notes This adds the required annotations to all code dependent on APIs unavailable for iOS extensions.
any ETA on this being merged? we'd like to be able to continue testing our apps against the beta SDKs. |
Guys, please take an action - last update since two weeks here, we have already Xcode beta 4 released (no changes so far in this bug regard). |
Hey guys. We're gonna try to address this in patch update next week. Will keep you posted. |
Is this supposed to be fixed in https://github.com/adjust/ios_sdk/releases/tag/v4.29.3 ? |
Nope. Will hopefully be addressed in upcoming 4.29.4. |
@cabeca I tried your PR and seems to be working fine. 👍 However, one question. Tried to walk through the path of this PR on my own and came up with just these changes. In comparison to yours, I'm not marking some of the methods you marked and it still seems to be working fine. Can you give that fork of mine a shot? It looks to me that Looking forward to hearing back from you. |
I tried on a separate branch with just the changes you mentioned and it worked fine on our project. Good simplification. I don't know why I added the extra annotations, probably a result of misinterpreting the error message that Xcode was throwing at me while I was trying to iteratively solve the errors. Please go ahead and close this PR and use your changes instead. Thank you for looking into this. |
iOS SDK v4.29.4 update with this fix will be shipped on Monday. |
Replace with #560. Thanks one more time for the contribution! |
Annotate code referencing APIs annotated as unavailable for iOS extensions.
Xcode 13 beta 3 introduces a breaking change related to API unavailable for iOS extensions: https://developer.apple.com/documentation/xcode-release-notes/xcode-13-beta-release-notes
This adds the required annotations to all code dependent on APIs unavailable for iOS extensions.