Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App setup #5

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

Shravankumarkarnati
Copy link

Overview

  • Follow up for PR scaffold project clean setup  #4
  • Removed unnecessary/unused packages from app package.json.
  • Updated react and react-dom to latest v18.
  • Removed jest and storybook - Planning to use vitest.
  • @storybook/builder-vite is not perfect yet - but works fine mostly. Will add that too in a follow up PR.

Testing

  • Starts and builds perfectly fine.
  • Verified manually that the eslint and stylelint configs are extended from the scaffold.

@poteirard
Copy link

I think it will be simple to use one of those base tsconfig files. There's one for vite!
https://github.com/tsconfig/bases/tree/main/bases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants