Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation of zh-tw #908

Merged
merged 1 commit into from
May 14, 2022
Merged

Update translation of zh-tw #908

merged 1 commit into from
May 14, 2022

Conversation

DejavuMoe
Copy link
Contributor

What does this PR change? What problem does it solve?

Update the translation of Prev Page and Next Page in Traditional Chinese

Was the change discussed in an issue or in the Discussions before?

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@sonarcloud
Copy link

sonarcloud bot commented May 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adityatelange
Copy link
Owner

adityatelange commented May 8, 2022

@ChiahongHong @yuyinws @DotnetChen Please review

@yuyinws
Copy link
Contributor

yuyinws commented May 9, 2022

@adityatelange I had review this PR, It's correct and can be merged.

@adityatelange
Copy link
Owner

@DejavuMoe can we include #914 as well with this

@DejavuMoe
Copy link
Contributor Author

DejavuMoe commented May 14, 2022

@DejavuMoe can we include #914 as well with this

I think #914 should not have much effect on Chinese translation.

In Chinese (either Simplified or Traditional Chinese), the previous or next button on a page and post should be different terms, and I think they should be translated separately, for example

For Pages

  • Previous and Next
  • 上一页下一页

For Posts

  • Previous or Next
  • 上一篇下一篇

image
image

🧐Any suggestions? Please~

@ChiahongHong @yuyinws @DotnetChen

@yuyinws
Copy link
Contributor

yuyinws commented May 14, 2022

@DejavuMoe @adityatelange
I think the better way is add two new keywords in i18n file to distinguish Page and Post. like this:

# en.yaml
- id: prev_page
  translation: "Prev"

- id: next_page
  translation: "Next"

- id: prev_post
  translation: "Prev"

- id: next_post
  translation: "Next"

In Chinese, It will be translated like this:

- id: prev_page
  translation: "上一页"

- id: next_page
  translation: "下一页"

- id: prev_post
  translation: "上一篇"

- id: next_post
  translation: "下一篇"

@DejavuMoe
Copy link
Contributor Author

@DejavuMoe @adityatelange I think the better way is add two new keywords in i18n file to distinguish Page and Post. like this:

# en.yaml
- id: prev_page
  translation: "Prev"

- id: next_page
  translation: "Next"

- id: prev_post
  translation: "Prev"

- id: next_post
  translation: "Next"

In Chinese, It will be translated like this:

- id: prev_page
  translation: "上一页"

- id: next_page
  translation: "下一页"

- id: prev_post
  translation: "上一篇"

- id: next_post
  translation: "下一篇"

@adityatelange @yuyinws
Yes, I think it's a good way, totally agree with the way #892 updated the translation.

@adityatelange
Copy link
Owner

How about we just have translations for 'next and previous' instead of 'next_page/next_post'? I hope that is doable.
The more translations more PRs harder will it be to maintain.
Although it already was next_page and never next_post, I think it will be fine if ee keep it as it is, if that's not a problem.

@DejavuMoe
Copy link
Contributor Author

How about we just have translations for 'next and previous' instead of 'next_page/next_post'? I hope that is doable. The more translations more PRs harder will it be to maintain. Although it already was next_page and never next_post, I think it will be fine if ee keep it as it is, if that's not a problem.

Mmmm, in Chinese, a separate next and previous should be a bit strange. But using next_page/next_post would indeed make the current i18n project more difficult (until all languages get updated contributions in time, otherwise it might break the current translations for some languages)

And the semantics of next_page should be stronger than next_post in Chinese, so I only updated the translation of previous_page - next_page in my PR, which is acceptable.

@adityatelange adityatelange merged commit cb9be55 into adityatelange:master May 14, 2022
romainx pushed a commit to romainx/hugo-PaperMod that referenced this pull request Jul 26, 2022
minyeamer pushed a commit to minyeamer/hugo-PaperMod that referenced this pull request Sep 16, 2022
dunklecat pushed a commit to dunklecat/hugo-PaperModX that referenced this pull request Oct 8, 2022
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants