Removed deprecated code breaking my hugo deployment #1620
Closed
+0
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This change appears to have fixed the problem I encountered when using this theme on the following Hugo version. Without this change, the following error would prevent builds: |
|
It works as intended, thanks for the fix! |
penglezos
approved these changes
Oct 25, 2024
penglezos
added a commit
to penglezos/penglezos.dev
that referenced
this pull request
Oct 25, 2024
Workaround for adityatelange/hugo-PaperMod#1573 Until adityatelange/hugo-PaperMod#1620 gets merged Signed-off-by: penglezos <[email protected]>
LSXiang
added a commit
to LSXiang/hugo-PaperMod
that referenced
this pull request
Oct 29, 2024
tuchaVshortah
added a commit
to tuchaVshortah/tuchaVshortah.github.io
that referenced
this pull request
Oct 30, 2024
… in Hugo 0.137.0. Implement taxonomy 'social' or use .Site.Params.Social instead. Fixed by using another fork of papermod with a fix applied: adityatelange/hugo-PaperMod#1620
kinshuk4
added a commit
to kinshuk4/hugo-paper-mod
that referenced
this pull request
Nov 3, 2024
|
Thanks for the PR. This is fixed with 65bd711 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
This PR removes deprecated
site.Socialreferences from Hugo templates and updates them to usesite.Params.socialexclusively. It eliminates deprecation warnings for Facebook and Twitter social configs and simplifies the logic for retrieving social media configuration values. These changes resolved deploy issues that I was experiencing - trunk appears to be broken.Key changes include:
opengraph.htmlto remove fallback tosite.Social.facebook_admintwitter_cards.htmlto remove fallback tosite.Social.twittersite.Socialin both template filesThis change resolves deployment issues caused by deprecated Hugo configuration syntax, ensuring compatibility with the latest Hugo versions and removing potential sources of errors or warnings during site builds.
PR Checklist