Skip to content

Commit

Permalink
backupccl: skipping restore-grant datadriven test
Browse files Browse the repository at this point in the history
Informs: cockroachdb#87129

Release note: None

Release justification: low risk test only change
  • Loading branch information
adityamaru committed Aug 31, 2022
1 parent 121ead5 commit 8ea1ba8
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
7 changes: 6 additions & 1 deletion pkg/ccl/backupccl/datadriven_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -388,12 +388,17 @@ func TestDataDriven(t *testing.T) {
ds := newDatadrivenTestState()
defer ds.cleanup(ctx)
datadriven.RunTest(t, path, func(t *testing.T, d *datadriven.TestData) string {

for v := range ds.vars {
d.Input = strings.Replace(d.Input, v, ds.vars[v], -1)
d.Expected = strings.Replace(d.Expected, v, ds.vars[v], -1)
}
switch d.Cmd {
case "skip":
var issue int
d.ScanArgs(t, "issue-num", &issue)
skip.WithIssue(t, issue)
return ""

case "reset":
ds.cleanup(ctx)
ds = newDatadrivenTestState()
Expand Down
3 changes: 3 additions & 0 deletions pkg/ccl/backupccl/testdata/backup-restore/restore-grants
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
skip issue-num=87129
----

# Ensure that non-cluster restores appropriately wipes the grants on the
# restored descriptors. Since we're not restoring the users, the users that
# the restoring descriptors reference may not be the same users as they
Expand Down

0 comments on commit 8ea1ba8

Please sign in to comment.