Skip to content

Commit

Permalink
persistedsqlstats: skip logical_plan_sampling_for_explicit_txn
Browse files Browse the repository at this point in the history
Skipping the test since its flaky.

Informs: cockroachdb#89861

Release note: None
  • Loading branch information
adityamaru committed Oct 27, 2022
1 parent f64c283 commit 057a415
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
6 changes: 6 additions & 0 deletions pkg/sql/sqlstats/persistedsqlstats/datadriven_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/sql/tests"
"github.com/cockroachdb/cockroach/pkg/testutils"
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
"github.com/cockroachdb/cockroach/pkg/util/leaktest"
"github.com/cockroachdb/cockroach/pkg/util/log"
Expand Down Expand Up @@ -151,6 +152,11 @@ func TestSQLStatsDataDriven(t *testing.T) {
dbName,
)
return fmt.Sprintf("%t, %t", previouslySampled, savePlanForStats)
case "skip":
var issue int
d.ScanArgs(t, "issue-num", &issue)
skip.WithIssue(t, issue)
return ""
}

return ""
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
skip issue-num=89861
----

# This test checks the expected behavior of logical plan sampling.
# Given a tuple of (db_name, implicitTxn, fingerprint string), the logical plan
# is only sampled if and only if no logical plan has been sampled for the given
Expand Down

0 comments on commit 057a415

Please sign in to comment.