Shutdown workqueue on close #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 18, 2014 15:35
* Allow users to set the size of the GirlFriday::WorkQueue by setting Blather::Client.queue_size. * The queue size is passed in as a named parameter in the last argument to Blather::Client.setup * If the queue size is 0, then #receive_data will process the incoming stanza immediately.
Since the handler_queue is lazily initialized, all we have to do at connection close time is shutdown the queue and nil it out. Any subsequent reference (such as in #receive_data) will automatically re-create it, if necessary.
* If it failed to open properly, @stream might not be set, which means that calling #close on the Blather::Client might not be safe (it will raise a StreamNotReady error in the bowels of EventMachine). * If a stream is not connected (i.e., there is no @stream or it's been stopped due to EM having called #unbind on it), then don't try to close it on Blather::Client#close
benlangfeld
added a commit
that referenced
this pull request
Aug 18, 2014
Shutdown workqueue on close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of 2 to help address #139
Depends on #140 (for lazy initialization of
handler_queue)Since the
handler_queueis lazily initialized, all we have to do at connection close time is shutdown the queue and nil it out. Any subsequent reference (such as in#receive_data) will automatically re-create it, if necessary.